-
Notifications
You must be signed in to change notification settings - Fork 31
Add macos support #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @SamNet-dev. I tested this on a Macbook Air M4. It works seamlessly. Also the "peers" command (needs sudo) works (see below image). My only question at this stage is how to choose the version. Feel free to edit as you wish!
|
|
Thanks a lot for putting this together and testing it on macOS, really appreciate it. I don’t have access to a Mac OS right now, so I can’t properly validate the changes on my side and I’m also really busy with other stuff. If you can, could you run a few different scenarios on macOS and confirm everything stays stable? For example:
If those look good, I can create a dedicated branch like macos-edition and bring your work in there so we can merge it cleanly with the current codebase and keep it maintained going forward. |
|
I was going to give this a run on my M1 Mac, but I was faced with the maxmind Geo database account creation requirement... Why not use something like Sample JSON response can be found here: The database can be downloaded and included in the package here: |
Thank you @SamNet-dev. Although it is not ideal to keep separate branches like this, but in the interest of time, I think would be the only option to keep a separate branch for mac version. I know you keep adding new features on Linux and the bash script is getting longer, which might cause feature porting painful. But let's be practical and focus on delivering the bear minimum for now :) If you don't mind, could you kindly create a new branch for macos, preferably from v1.0.2 tag? I started my fork from there and it will be much easier to avoid the branch conflicts. I want to thank you for starting this project. It's been really fun for me doing something useful at this critical point of history! Keep it up! |
This is a great point @EmranMR. I did this for the first version and was trying to get something working to start the nodes faster! :) But obviously there is always room for improvement and I appreciate your interest. I would say let's hear back from @SamNet-dev about the new mac-specific branch and generate the first working tag for it. Then I will ping you in case you want to make the changes you suggested above. Sounds good? |
|
Hey @PouriaCh, the macos-edition branch is now live, created from the v1.0.2 tag just as you requested! Go ahead and open a new PR targeting that branch whenever you're ready, and we can close this one out. Really appreciate the effort you've put into this, excited to see macOS support coming together. @EmranMR you're welcome to jump in on the macOS branch too once the first PR lands! |

Add macOS (Apple Silicon) support and improve Docker/GeoIP handling