fix: Copilot provider can hang forever when a stream consumer goes away#370
Closed
sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
Closed
fix: Copilot provider can hang forever when a stream consumer goes away#370sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Copilot was writing directly to the internal event channel. If a consumer disconnected or cancelled and stopped draining events, the buffered channel could fill and leave the producer goroutine blocked forever on
events <- .... That preventedClose()from finishing, leaked the HTTP response body, and could leave runs or sessions stuck instead of shutting down cleanly.