fix: Claude CLI conversation state survives resets and leaks old history into new chats#400
Closed
sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
Closed
Conversation
…ory into new chats
This was referenced Apr 19, 2026
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
ResetConversation()hook toClaudeBinProviderthat clears the persisted Claude CLI resume state (sessionIDandmessagesSent) so fresh conversations do not reuse the previous Claude session. Also add a regression test covering the reset behavior.Why
Engine.ResetConversation()already forwards resets to providers that implement a reset hook, butClaudeBinProviderwas not implementing one even though it caches resume state across turns. That let supposedly fresh conversations keep resuming the old Claude CLI session, skip re-sending the full prompt/system instructions, and leak stale context into new chats.