fix: parallel tool execution launches an unbounded goroutine per tool call#529
Closed
sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
Closed
fix: parallel tool execution launches an unbounded goroutine per tool call#529sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
sam-saffron-jarvis wants to merge 1 commit intoSamSaffron:mainfrom
Conversation
Owner
|
Closing as superseded by the parallel tool cap merged in db938ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bound parallel tool execution in
Engine.executeToolCallswith a small worker pool instead of launching one goroutine per tool call.Also adds a regression test that verifies parallel tool execution stays concurrent while respecting the configured worker limit.
Why
A single model response could previously fan out into an unbounded number of concurrent local tool executions, which can oversubscribe CPU, disk, and process limits and hurt overall throughput. Using a bounded worker pool preserves parallel execution while adding backpressure and preventing runaway goroutine/process fan-out.