Skip to content

fix: Config load eagerly resolves credentials for every configured provider, not just the active one#601

Merged
SamSaffron merged 1 commit intoSamSaffron:mainfrom
sam-saffron-jarvis:feat/codereview-d541d09a
May 8, 2026
Merged

fix: Config load eagerly resolves credentials for every configured provider, not just the active one#601
SamSaffron merged 1 commit intoSamSaffron:mainfrom
sam-saffron-jarvis:feat/codereview-d541d09a

Conversation

@sam-saffron-jarvis
Copy link
Copy Markdown
Contributor

What

  • stop config.Load() from eagerly resolving every configured LLM provider at startup
  • resolve credentials only for the default provider during load, then resolve other configured providers on demand when they are actually used
  • add targeted regression tests covering the deferred gemini-cli case and on-demand resolution for non-default providers

Why

Resolving every provider on every startup makes cold start latency scale with the total number of configured providers and forces unnecessary work for unused integrations, including provider-specific credential loading like gemini-cli OAuth reads. This keeps startup fast while preserving existing behavior once a non-default provider is selected or otherwise accessed.

@SamSaffron SamSaffron merged commit 9205005 into SamSaffron:main May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants