fix: Failed jobs cleanup attempts are recorded as successful and skipped for a full interval#727
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
Conversation
…ped for a full interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
maybeRunCleanup()to recordlastCleanupCompletedonly afterpruneOldData()succeedsWhy this is high-value
A transient cleanup failure was being treated as a successful cleanup run. That caused the scheduler to skip retention cleanup for the full configured interval, which defeats the existing error-backoff retry path and can let
job_runs_v2/job_run_events_v2grow unchecked for hours or days. This fix ensures failed cleanup attempts keep retrying on the scheduler error delay until pruning succeeds.Validation
gofmt -w cmd/serve_jobs_v2.go cmd/serve_jobs_v2_test.gogo build ./...go test ./...git diff --statgit diff --check