fix: Config saves are non-atomic and can corrupt config.yaml on interruption#745
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Config saves are non-atomic and can corrupt config.yaml on interruption#745sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
Owner
|
Closing in favor of applying the worthwhile changes directly on main staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
os.WriteFilecalls used by config saves ininternal/config/config.gowith a smallwriteFileAtomicallyhelperfsyncs it, applies the expected mode, and then atomically renames it into placerewriteProviderEnvSectionsSave0600config.yamlcontents remain untouchedWhy this is high-value
~/.config/term-llm/config.yamlis core persisted state for provider defaults and auth-related settings. Before this change, these saves truncated the live file and then rewrote it in place. If the process was interrupted mid-write, or the write only partially completed, users could be left with an empty or malformed config and broken startup/auth flows.With the temp-file + sync + rename pattern, the old config stays intact until the replacement file is fully written and ready, which removes the torn-write corruption mode from these paths.
Validation
gofmt -w internal/config/config.go internal/config/config_test.gogo build ./...go test ./internal/configgo test ./...git diff --check