Skip to content

warpsql: Add Citus Extension#12

Merged
ChakshuGautam merged 2 commits intoSamagra-Development:mainfrom
jayanth-kumar-morem:main
Apr 20, 2023
Merged

warpsql: Add Citus Extension#12
ChakshuGautam merged 2 commits intoSamagra-Development:mainfrom
jayanth-kumar-morem:main

Conversation

@jayanth-kumar-morem
Copy link
Copy Markdown
Collaborator

  1. Update Dockerfile's
  2. Install Citus dependencies (curl, jq)
  3. Add build dependencies for Citus (gcc, libc-dev, make, curl-dev, lz4-dev, libxslt-dev, libxml2-dev)
  4. Download and install Citus with specified version
  5. Remove build dependencies and cleanup temporary files after Citus installation
  6. Add Citus extension smoke tests to GitHub Actions workflow
  7. Update Bitnami entrypoint script to preload Citus extension
  8. Test Citus extension and distributed table creation in smoke tests
  9. Ensure logs are displayed for debugging purposes

1. Update Dockerfile
2. Install Citus dependencies (curl, jq)
3. Add build dependencies for Citus (gcc, libc-dev, make, curl-dev, lz4-dev, libxslt-dev, libxml2-dev)
4. Download and install Citus with specified version
5. Remove build dependencies and cleanup temporary files after Citus installation

Fixes: #3
1. Add Citus extension smoke tests to GitHub Actions workflow
2. Update Bitnami entrypoint script to preload Citus extension
3. Test Citus extension and distributed table creation in smoke tests
4. Ensure logs are displayed for debugging purposes

Fixes: Samagra-Development#11
@jayanth-kumar-morem
Copy link
Copy Markdown
Collaborator Author

Hi @ChakshuGautam, I have added the smoke tests and tested the smoke tests workflow in my forked repo. Could you approve the workflow here as well.

@jayanth-kumar-morem jayanth-kumar-morem mentioned this pull request Apr 14, 2023
Closed
4 tasks
@ChakshuGautam
Copy link
Copy Markdown
Collaborator

ChakshuGautam commented Apr 15, 2023

Hey @jayanth-kumar-morem shared comments on the PR.

@jayanth-kumar-morem
Copy link
Copy Markdown
Collaborator Author

Hi @ChakshuGautam , couldn't find any comments on the PR 😲 ?

Comment thread Dockerfile
jq

# Install Citus
ARG CITUS_VERSION="11.2.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose this to makefile and subsequently expose this to the CI to test out various versions?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can be a future task, I believe, as of now, we are in the development phase of adding extensions and if we add version variables to CI now itself, it would add more jobs, which I believe in the development phase is unnecessary. Sticking to the smoke tests solves the purpose in the dev phase.

Comment thread bitnami/Dockerfile
ARG PG_VERSION
FROM bitnami/postgresql:${PG_VERSION}
ARG PG_VERSION
ARG CITUS_VERSION="11.2.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose this to makefile and subsequently expose this to the CI to test out various versions?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@ChakshuGautam
Copy link
Copy Markdown
Collaborator

Ahh, my bad. Can you check now?

@ChakshuGautam ChakshuGautam merged commit b752996 into Samagra-Development:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants