warpsql: Add Citus Extension#12
Conversation
jayanth-kumar-morem
commented
Apr 14, 2023
- Update Dockerfile's
- Install Citus dependencies (curl, jq)
- Add build dependencies for Citus (gcc, libc-dev, make, curl-dev, lz4-dev, libxslt-dev, libxml2-dev)
- Download and install Citus with specified version
- Remove build dependencies and cleanup temporary files after Citus installation
- Add Citus extension smoke tests to GitHub Actions workflow
- Update Bitnami entrypoint script to preload Citus extension
- Test Citus extension and distributed table creation in smoke tests
- Ensure logs are displayed for debugging purposes
1. Update Dockerfile 2. Install Citus dependencies (curl, jq) 3. Add build dependencies for Citus (gcc, libc-dev, make, curl-dev, lz4-dev, libxslt-dev, libxml2-dev) 4. Download and install Citus with specified version 5. Remove build dependencies and cleanup temporary files after Citus installation Fixes: #3
1. Add Citus extension smoke tests to GitHub Actions workflow 2. Update Bitnami entrypoint script to preload Citus extension 3. Test Citus extension and distributed table creation in smoke tests 4. Ensure logs are displayed for debugging purposes Fixes: Samagra-Development#11
|
Hi @ChakshuGautam, I have added the smoke tests and tested the smoke tests workflow in my forked repo. Could you approve the workflow here as well. |
|
Hey @jayanth-kumar-morem shared comments on the PR. |
|
Hi @ChakshuGautam , couldn't find any comments on the PR 😲 ? |
| jq | ||
|
|
||
| # Install Citus | ||
| ARG CITUS_VERSION="11.2.0" |
There was a problem hiding this comment.
Should we expose this to makefile and subsequently expose this to the CI to test out various versions?
There was a problem hiding this comment.
Yes, this can be a future task, I believe, as of now, we are in the development phase of adding extensions and if we add version variables to CI now itself, it would add more jobs, which I believe in the development phase is unnecessary. Sticking to the smoke tests solves the purpose in the dev phase.
| ARG PG_VERSION | ||
| FROM bitnami/postgresql:${PG_VERSION} | ||
| ARG PG_VERSION | ||
| ARG CITUS_VERSION="11.2.0" |
There was a problem hiding this comment.
Should we expose this to makefile and subsequently expose this to the CI to test out various versions?
|
Ahh, my bad. Can you check now? |