Tooltip runs out of bounds

[Keith94]

mpv Information

Reproduction Steps

1. show_title=no
2. show_chapter_title=no
3. Play https://www.youtube.com/watch?v=b1Fo_M_tj6w
4. Hover the beginning of seekbar

Expected Behavior

Chapter title kept in bounds

Actual Behavior

The beginning of the chapter title is cut off

Log File

No response

I carefully read all instructions and confirm that I did the following:

• I tested with the latest mpv version to validate that the issue is not already fixed.
• I provided all required information.

[nekoxuee]

Currently, to avoid at the edges, the script changes the anchor point based on position. For some reason this is not done in the chapter title.

This could be fixed by doing the same there, but I don't think the anchor shift is a good solution to begin with, so it would be like a patch.

Edit: I could change it to calculate the text width to clamp the position at the edge of the video. But, since the script is being cleaned up, not sure if we want to patch it for now and revisit it once the cleanup is done.

[Samillion]

Currently, to avoid at the edges, the script changes the anchor point based on position. For some reason this is not done in the chapter title.

Indeed. This whole block can be simplified. I am not sure why I re-did math and positioning for chapter title in that position. Will do a patch now for a test.

[Samillion]

Test script: modernz.lua
Commit: c695d84

Changes:

• Fix chapter title tooltip without thumbfast, show_title=no and show_chapter_title=no
  • Instead of redoing everything, just use the already existing positioning logic

[nekoxuee]

Indeed. This whole block can be simplified. I am not sure why I re-did math and positioning for chapter title in that position. Will do a patch now for a test.

By the way, I have a fix but taking a different approach on tooltip positioning, is that something worth pursuing or would you rather leave it for later?

[Samillion]

is that something worth pursuing or would you rather leave it for later?

Improvements are always welcome. Do you want me to delete this patch?

[nekoxuee]

script: modernz.lua
commit: 664c53a

Changed what I explained here based on how uosc does it (yes I copied them):

Edit: I could change it to calculate the text width to clamp the position at the edge of the video. But, since the script is being cleaned up, not sure if we want to patch it for now and revisit it once the cleanup is done.

Also made the chapter title always show when there is no thumbnail to make it consistent with the thumbnail enabled behaviour.
Currently the tooltips are forced to be centred on the thumbnail but changing a few lines can make them move independently until they hit the border.

[Samillion]

Beautiful, definitely more consistent that way when thumbfast is used or not.

Question: Do we want it showing when show_chapter_title=yes and no thumbfast? Since the way we have it now, hover pos forces chapter title to change.

Genuine question, not sure what's best here.

[Samillion]

Ah, the overall tooltip positioning is awesome now. That measure text length helper is very nice.

We had a problem with locales (long phrases), now it's displayed perfectly.

[Keith94]

script: modernz.lua
commit: 664c53a

Thanks, works perfectly... tooltip cannot run away anymore.

[Samillion]

Not showing chapter tooltip while using:

# no thumbfast, chapter enabled, title disabled
show_title=no
show_chapter_title=yes

Would be consistent with:

# no thumbfast. chapter disabled, title enabled
show_title=yes
show_chapter_title=no

Both force either title or chapter title to show the currently hovered chapter.

[Samillion]

-                       if thumbfast.disabled then
+                       if thumbfast.disabled and not user_opts.show_title and not user_opts.show_chapter_title then
                            if chapter_text and osd_w and r_w > 0 then
                                local titleY = ty - (user_opts.time_font_size * 1.3)
                                elem_ass:new_event()
                                elem_ass:pos(tx, titleY)
                                elem_ass:an(2)
                                elem_ass:append(slider_lo.tooltip_style)
                                ass_append_alpha(elem_ass, slider_lo.alpha, 0)
                                elem_ass:append(chapter_text)
                            end
                        -- thumbfast

[nekoxuee]

Beautiful, definitely more consistent that way when thumbfast is used or not.

Question: Do we want it showing when show_chapter_title=yes and no thumbfast? Since the way we have it now, hover pos forces chapter title to change.

Genuine question, not sure what's best here.

Sorry, I used thumbfast for so long that I was oblivious of the fact that the script replaces the video title with the chapter title.

Seems like this behaviour was taken from stock osc back in 2022 cyl0/ModernX@3e7c3a8, then later that year po5 added the chapter title above the thumbnail.

The question is, do we want to keep the title replacement, or should we move toward the tooltip approach?
Either way is just reverting the if statement or removing the block of code that replaces the title.

[Samillion]

Sorry, I used thumbfast for so long that I was oblivious of the fact that the script replaces the video title with the chapter title.

No worries at all, this is a great alternative method, you've done great. I absolutely love that helper function.

Feel free to PR whenever you want.

Seems like this behaviour was taken from stock osc back in 2022 cyl0/ModernX@3e7c3a8, then later that year po5 added the chapter title above the thumbnail.

It's the same when thumbfast is enabled on ModernZ. However, without thumbfast, it's force chapter title if title or chapter_title are enabled.