osc sometimes breaks completely on startup

[Keith94]

oKEBj9dXTJ.mp4

This one is weird because it's not reproduced consistently. Took me 5 tries above to get it to happen. But I suspect if you set fullscreen=yes in your mpv.conf and have your mouse cursor in a specific spot like I did, the osc will break/doesn't respond to mouse input

I'll try to add better STR later but I don't have time right now

[Samillion]

Could you check memory (RAM) spikes? I have a feeling this is due to spikes. Just want to make sure before going deeper.

As in, while trying to reproduce this, keep your eye on cpu/ram/gpu spikes.

Final question, does it happen with all videos or HQ ones only? (ie: 2k+)

My initial gut is telling me this is due to processing, and I bet it will show in --v log as a slow warning or as a timeout.

[Samillion]

Final question, does it happen with stock osc, with the same shaders/config you have?

[Keith94]

It happens with low bitrate stuff, like vertical videos too. RAM and CPU looks pretty normal to me?

After several attempts I could not reproduce when using default OSC or when using zydezu/ModernX fork

It also happens with modernxlite.lua from your old commits, but it happens less frequently.

Only thing I set with mpv.conf was fullscreen.

It seems to happen if you move your mouse cursor at just the right moment in time...
But the osc doesn't completely break.. it still responds to inputs like space bar. I think something is breaking with cursor events or something, because it won't respond to my cursor movement even on first try.

uKeeMudiwf.mp4

[Keith94]

I also just added msg-level=all=trace and log-file=output.txt to get the log if that helps:

output.txt

p.s. don't know if related but log file was spamming [ 2.438][t][input] No key binding found for key 'MOUSE_MOVE'.

[Samillion]

Noted. Thank you very much for your thorough testing. I'll work on a fix very soon.

[Keith94]

No problem hope it helps. Did you happen to find the culprit?

[Samillion]

Could you try to reproduce it on this version please:
https://github.com/Samillion/ModernZ/blob/dev_oscnovid/modernz.lua

[Keith94]

https://github.com/Samillion/ModernZ/blob/dev_oscnovid/modernz.lua

I can reproduce, sadly

[Samillion]

Does it only happen with bottom hover set to yes?

I apologize for all the questions, I'm unable to re-produce, so I have to rely on statements to try and fix it.

[Keith94]

It happens with both yes and no. Trying to get some solid steps for you but it's pretty random

[Samillion]

So if I'm understanding this right, with fullscreen=yes, sometimes it doesn't detect mouse movement so the OSC doesn't show.

If that happens, then mouse movement doesn't trigger show/hide OSC and all mouse actions stop working? (ie: clicking play/pause)

[Keith94]

Yep, that's accurate. Still haven't gotten to why though. Could still be performance related like you mentioned earlier.

[Samillion]

Nah, my gut feeling was wrong on that one. Your hardware shouldn't be affected at all by something like this, especially if it's happening with ModernZ only.

Could you try to reproduce with this one please:
https://github.com/Samillion/ModernZ/blob/dev_oschaltfs_fix/modernz.lua

[Keith94]

Can still repro the issue