Title disappears if commands blank

[Keith94]

mpv Information

Details & Reproduction Steps

show_title=yes
title_mbtn_left_command=
title_mbtn_right_command=

Title above osc does not show up.

Log File

No response

I carefully read all instructions and confirm that I did the following:

• I tested with the latest mpv version to validate that the issue is not already fixed.
• I provided all required information.

[Samillion]

This is intentional, from an old request made by you in #241 if you remember. Easy to fix, should I?

Current:

    local no_title =
        ((user_opts.title_mbtn_left_command == "" or user_opts.title_mbtn_left_command == "ignore") and
        (user_opts.title_mbtn_right_command == "" or user_opts.title_mbtn_right_command == "ignore")) or
        not user_opts.show_title

Fix:

    local no_title = not user_opts.show_title

[Keith94]

Oh, I thought I requested something about adjusting the osc height (to be shorter) when title clicks were set to ignore, or something. Unless I've forgotten some details.

However, I didn't expect the title to disappear completely. Just expected clicks to go through it.

[Samillion]

Indeed, osc height now actually performs a change and not an invisible boundary.

Should I apply the suggested fix?

[Keith94]

I just tried the fix, but the clicks don't go through the title as expected. It seems like there's still an offset being applied.

[Samillion]

The issue is the title is there, so it's a visible element, that's why clicks won't go through. It's the OSC not the video.

Not sure what the best way to fix this, you'd basically need to address a scenario where title commands do not exist, yet osc_height does not account for it and at the same time osc_height remains the same.

[Keith94]

Yeah you're exactly right about that. I'll try to think of something.

[Samillion]

I think because it's a transparent fade gradient, it makes it seem like clicks should pass through.

It's like clicking on the title area in osc.lua (inside osc box).

The difference here is "transparency", it makes it feel wrong, but it's still a box nevertheless.

A render change would need to create two zones on top of osc.

• Left side: title, chapter title (extends with title/chapter width)
• Right side: time codes

That way, the middle area is not osc (between sides)

I'll use my legendary elite drawing skills to demonstrate this

[Keith94]

I thought it might be possible to tweak offset when command is blank to allow clickthrough, but I don't feel like implementing it now.

To keep the fix simple, can always change it back to the old way #643 (comment)

[Samillion]

It's not impossible to do, just needs a redesign.

Creating the two zones on top of the osc to be independent (yet connected to osc), would probably be the best solution.

It's similar to how uosc does it (between sides)

Which would be good in modern-image as well, to keep osc layer impact minimal

But, easier said than done lol. Doable though, definitely. Just needs a sit down and dedication.

[Samillion]

The difference here is "transparency", it makes it feel wrong, but it's still a box nevertheless.

Can basically see what I mean if you set fade_blur_strength to 0

[Keith94]

That does make more sense. The transparency part was just misleading me I guess lol.

[Samillion]

Yeah 😆 It's a box pretending to be a fade, basically.

Should I apply the fix so that commands don't make the title disappear?

[Keith94]

Should I apply the fix so that commands don't make the title disappear?

Yes please~~