deadzone_hide=timeout sometimes not working

[Keith94]

mpv Information

Details & Reproduction Steps

1. Set in modernz.conf

hidetimeout=3000
deadzone_hide=timeout

2. Go into fullscreen
3. Move cursor to bottom edge of the screen
4. Move cursor to the middle (deadzone)

Sometimes the osc hides instantly, and sometimes it respects hidetimeout.

For example in the video, on first try it hides instantly, 2nd try hides after 3 seconds, then hides instantly again.

mpv_LvQT1t1fZJ.mp4

Log File

No response

I carefully read all instructions and confirm that I did the following:

• I tested with the latest mpv version to validate that the issue is not already fixed.
• I provided all required information.

[Samillion]

Hmm, it's supposed to hide instantly only if it reaches top bar zone (or vice versa).

Will be back home in a few hours. Thank you for the report.

[Samillion]

Test script: modernz.lua
Commit: 09a030b

Changes:

• Respect hidetimeout in deadzones with deadzone_hide=timeout
  • Don't call hide functions when using deadzone_hide=timeout and reaching deadzone areas, let it timeout normally instead.

[Samillion]

This basically fixes it, but I'm compelled to ask: (question, not suggestion, imposition or rejection)

• Which behavior is better?

In current main, one or the other can be shown with timeout. Meaning, if you're showing bottom bar and hover to top bar, the former hides instantly.

With this fix, both can be shown at the same time if you hover fast enough.

It's not a big deal nor is it a bad behavior, just merely asking which do you think would be a better behavior.

[Keith94]

Sam the Legend.

Which behavior is better?

Well, the "former hides instantly" feels wrong to me (when set to "timeout"). When value is "instant" it feels more appropriate.

I noticed an odd behavior when testing this out.

Basically hovering a subsequent bar seems like it resets hidetimeout for the intial bar? So, if you move cursor to the bottom bar, then move your cursor to the top bar before the bottom hides, it will reset the timeout for the bottom bar. So when moving your cursor to deadzone, both bars hide simultaneously. Is it supposed to work like that?

[Samillion]

Is it supposed to work like that?

Technically, yes. As in, it's how I implemented it lol.

You see, deadzone_hide=timeout calls request_tick(), which in turn will call run_autohide() (state.hide_timer).

[Keith94]

Okay perfect, I just needed to know. Lol