fix: improve consistency for width and coordinate values #242
Conversation
Improves the hit boxes for time stamps to be more accurate, and adjusts the chapter title separator to be more consistent when time stamp width changed and for the tooltip.
|
Thank you very much for your efforts. By any chance you're using a custom font for mpv? I think that's why we're seeing different results.
|
|
Actually, yeah I am. Oops. I will test again. |
|
Crap. The font was messing things up. I was using Open Sans Semi Bold. Everything looks ok with default font. Nevermind lol. |
|
It honestly brings up a good point. One of the main reasons why I hate OSC being libass based. It is essentially tricking the system into displaying text as elements. Which makes something as simple as changing font type a breaking change. I agree with you that the default font isn't good, but I can't think of a good way to use a better replacement that wouldn't apply workload on the users. Maybe one day we should discuss this in detail. |
|
Yeah, I had no idea the geometry was that delicate until you mentioned custom font. On one hand, it's nice that people can choose their own font, but it's very much "at your own risk" because of the breakage. We would have to either support a new, specific font type, which would break a lot of configurations, or simply leave it as is. |
2 participants
Improves the hit boxes for time stamps to be more accurate, and adjusts the chapter title separator to be more consistent when time stamp width changed and for the tooltip.