Skip to content

feat: dynamic time format based on video duration#50

Merged
Samillion merged 1 commit intoSamillion:mainfrom
nekoxuee:feat/dynamic-time-format
Oct 18, 2024
Merged

feat: dynamic time format based on video duration#50
Samillion merged 1 commit intoSamillion:mainfrom
nekoxuee:feat/dynamic-time-format

Conversation

@nekoxuee
Copy link
Copy Markdown
Contributor

I noticed the time display was always showing hours even for short videos (like 00:25:59 for a 25-minute video), which felt a bit cluttered and always bothered me. Most other players like YouTube only show hours when needed, so I thought we could do the same.

What's changed?

  • Short videos: 03:24 instead of 00:03:24
  • Long videos: still 01:23:45 (no change)
  • Everything else (milliseconds toggle, remaining time) works exactly the same

Let me know what you think!

@Anthonyy232
Copy link
Copy Markdown
Contributor

Would be a dope change

@Samillion
Copy link
Copy Markdown
Owner

Absolutely love it. Thank you very much.

@Samillion Samillion merged commit 3db9500 into Samillion:main Oct 18, 2024
@Samillion
Copy link
Copy Markdown
Owner

I need to update the preview images/video to showcase this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants