fix: respect playback state after dragging seekbar#514
Merged
Conversation
Contributor
|
I was trying to find what did I do to fix this a few months ago, but can't find the changes because I did a single commit with a lot of changes and I don't remember. Doing it this way seems to work, and the icon doesn't change while paused and dragging. Don't know if there are any drawbacks. - state.playing_and_seeking = true
- if mp.get_property("pause") == "no" and user_opts.mouse_seek_pause then
+ if not state.playing_and_seeking and mp.get_property("pause") == "no" and user_opts.mouse_seek_pause then
+ state.playing_and_seeking = true |
|
Change in PR works. |
Owner
Author
Out of curiosity, could you share the trace for the crash? I'm not at home right now so I'm unable to test. If it's not a bother, of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #513
Changes:
mouse_seek_pause=yes