Skip to content

fix: respect playback state after dragging seekbar#514

Merged
Samillion merged 1 commit intomainfrom
fix_playback_state_paused
Mar 9, 2026
Merged

fix: respect playback state after dragging seekbar#514
Samillion merged 1 commit intomainfrom
fix_playback_state_paused

Conversation

@Samillion
Copy link
Copy Markdown
Owner

Fixes: #513

Changes:

  • Keep track of pause state when a drag event occurs, to respect playback state after event ends with mouse_seek_pause=yes

@nekoxuee
Copy link
Copy Markdown
Contributor

nekoxuee commented Mar 9, 2026

I was trying to find what did I do to fix this a few months ago, but can't find the changes because I did a single commit with a lot of changes and I don't remember.

Doing it this way seems to work, and the icon doesn't change while paused and dragging. Don't know if there are any drawbacks.

- state.playing_and_seeking = true
-    if mp.get_property("pause") == "no" and user_opts.mouse_seek_pause then
+ if not state.playing_and_seeking and mp.get_property("pause") == "no" and user_opts.mouse_seek_pause then
+    state.playing_and_seeking = true

@InterestingFallacy
Copy link
Copy Markdown

Change in PR works.
@Xurdejl's change crashes script when applied on top of current Master.

@Samillion
Copy link
Copy Markdown
Owner Author

@Xurdejl's change crashes script when applied on top of current Master.

Out of curiosity, could you share the trace for the crash? I'm not at home right now so I'm unable to test.

If it's not a bother, of course.

@Samillion Samillion merged commit f1c7c19 into main Mar 9, 2026
@Samillion Samillion deleted the fix_playback_state_paused branch March 9, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect playback state after dragging seekbar

3 participants