Skip to content

feat: add zones_hover_mode option#539

Merged
Samillion merged 3 commits intomainfrom
feat_zones_hover_mode
Mar 14, 2026
Merged

feat: add zones_hover_mode option#539
Samillion merged 3 commits intomainfrom
feat_zones_hover_mode

Conversation

@Samillion
Copy link
Copy Markdown
Owner

Fixes: #536

Changes:

  • Add zones_hover_mode option to replace both bottomhover and independent_zones options
    • bottomhover and independent_zones options are completely removed

Zone hover modes:

  • always: show both top and bottom bars on any mouse movement
  • zones: show both top and bottom bars when mouse hovers either zone's area
  • independent: show only the specific bar (top or bottom) when area zone is hovered

cc @Xurdejl @Keith94

@nekoxuee
Copy link
Copy Markdown
Contributor

I was about to reply to the other comment so I will write it here:

I like the idea of making the values one word.
Should the option be named osc_trigger so it describes what it controls? I initially threw zones_hover_mode as a quick example without much thought.

@Samillion
Copy link
Copy Markdown
Owner Author

Samillion commented Mar 13, 2026

Should the option be named osc_trigger so it describes what it controls? I initially threw zones_hover_mode as a quick example without much thought.

I'm fine with any name. It's so difficult naming things lol. Maybe we should ask AI to come up with a meaningful and not confusing name.

I like the idea of making the values one word.

Yeah, makes it easier for the user.

@Keith94
Copy link
Copy Markdown
Contributor

Keith94 commented Mar 13, 2026

This is a good solution; works well for me!

@Samillion
Copy link
Copy Markdown
Owner Author

In theory, zones_hover_mode (with the modes) is self explanatory. Plus, it covers any zones we might add in the future.

For example, if we ever want to do something like uosc's volume bar thing.

As I said though, I'm fine with any name.

@Keith94
Copy link
Copy Markdown
Contributor

Keith94 commented Mar 13, 2026

Make the mode independent by default like before?

@Samillion
Copy link
Copy Markdown
Owner Author

Make the mode independent by default like before?

After the ModernZ defaults discussion, I decided to check and came to the following conclusions:

  • Most users have title-bar=yes (unless mpv decides to change its default in the future)
  • Most embedded players (ie: Youtube), on hover = show (ie: always)

Having it default to always will be consistent with common behavior. If user prefers a specific behavior, the option is there to adjust. They decide, basically.

What do you think?

@Keith94
Copy link
Copy Markdown
Contributor

Keith94 commented Mar 13, 2026

Ya, sounds great to me.

@nekoxuee
Copy link
Copy Markdown
Contributor

Looks good

@Samillion Samillion merged commit ca12071 into main Mar 14, 2026
@Samillion Samillion deleted the feat_zones_hover_mode branch March 14, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make bottomhover always on and remove the toggle option

3 participants