feat: wrap seek bar tooltips with a box, similar to thumbnail

[Samillion]

Fixes: #567

Changes:

• Wrap time and chapter seek bar tooltips with a box, same as thumbnail.
• Only draw tooltip box for seekbar
• Scale with tooltip font size, not time stamp font size
• Increase spacing between seek bar tooltips
• Adjust tooltip opacity, corner radius and horizontal padding
• Change default value of seek_hover_tooltip_h_offset to 5
• Add tooltip_seek to osc_styles

[Keith94]

Hmm, if you increase the UI scale above 1, then the tooltip background starts to increasingly run away off screen edge.
This is what 3 looks like.

[Samillion]

Is that an issue though? Genuinely asking. The text positioning is correct, right? At the far edge of the slider (last pos)

[Keith94]

Is that an issue though? Genuinely asking. The text positioning is correct, right? At the far edge of the slider (last pos)

The text is correct.

Using local pad_h, pad_v = 0, 3 fixes that padding issue. Might be biased, but I would make it default to avoid potential issues lol.

[Samillion]

Using local pad_h, pad_v = 0, 3 fixes that padding issue. Might be biased, but I would make it default to avoid potential issues lol.

0 only when no thumbfast or for all scenarios?

[Keith94]

With thumbfast you would run into the same issue. Unless you would rather add a user option.

[Samillion]

Would pad_h value of 2 work? I don't have videos with long chapters on hand at the moment.

What I mean is, does pad_h have to be 0? On reasonable scales.

[Keith94]

Would pad_h value of 2 work?

Yeah, pad_h of 2 looks perfect up to scale values of around 1.4 on my video. At 1.5 scale it starts to clip the edge.
But that should be a good solution.

[Samillion]

Done. Lowered horizontal padding to 2 from 5.

[Keith94]

Thank you. How can we run it borderless? Border outline is always enabled, right?

[Samillion]

Done.

[Keith94]

That's awesome. Such an improvement over how it looked yesterday haha.

Btw, if you like the border, I'm not against having it available. I just wanted a way to disable lol. What you have now is good for sure tho.

[Samillion]

Btw, if you like the border, I'm not against having it available. I just wanted a way to disable lol. What you have now is good for sure tho.

I really like your idea of no border, makes it blend in, looks right.

I'll merge tomorrow ish to see if @Xurdejl has suggestions, since he suggested the tooltips to be wrapped like that.

I'll have to re-do a lot of preview images and video 😭 but I won't do it right away, because I saw a sneaky Xurdejl messing with purple variants for seekbar lol.

Edit:
Speaking of purple. I genuinely love the orange default colors. I have no idea why, but it looks nice and unique ish.

[Keith94]

If you don't mind more suggestions, should tooltip match the osc color of #000000 ? If not at least be a bit darker so it's easier to read.

Right now it follows thumbnail_border_color but it may not be super obvious that it's tied to tooltip. Should it be renamed?

I genuinely love the orange default colors. I have no idea why, but it looks nice and unique ish.

Of course, orange is always sexy, but I'm very biased in that regard lol.

[Samillion]

If you don't mind more suggestions, should tooltip match the osc color of #000000 ? If not at least be a bit darker so it's easier to read.

Good idea. Done.

[Keith94]

The radius is at 8 but what do you think about 12. More pill shaped like that.

[Samillion]

Sorry, before I address that, do we still need seek_hover_tooltip_h_offset option?

That was initially added to adjust height in case of overlap. With this, overlap is fine, right? In other words, should the option be removed?

[Keith94]

The only way it's gonna overlap now is if you push hover_button_size to some extreme value.

But hover size ≤ 115 is perfect for most cases anyway. Should be good to remove.

[Samillion]

The radius is at 8 but what do you think about 12. More pill shaped like that.

12 feels a bit too much, no? even the round corner ends with a pointy center.

[nekoxuee]

I'll merge tomorrow ish to see if @Xurdejl has suggestions, since he suggested the tooltips to be wrapped like that.

Looks good.

I'll have to re-do a lot of preview images and video 😭 but I won't do it right away, because I saw a sneaky Xurdejl messing with purple variants for seekbar lol.

I wasn't really. I just don't remove old stuff from the conf file

Edit: Speaking of purple. I genuinely love the orange default colors. I have no idea why, but it looks nice and unique ish.

No need to change them, orange is ok

The radius is at 8 but what do you think about 12. More pill shaped like that.

12 feels a bit too much, no? even the round corner ends with a pointy center.

if you want to make it pill shaped what about (fs + 2 * pad_v) / 2)

[Samillion]

if you want to make it pill shaped what about (fs + 2 * pad_v) / 2)

Ah, to scale it with tooltip font size to ~10 radius? I'm ok with that if you guys think it looks better.

[Keith94]

if you want to make it pill shaped what about (fs + 2 * pad_v) / 2)

Ah, to scale it with tooltip font size to ~10 radius? I'm ok with that if you guys think it looks better.

Can you make a before and after demo. Ideally it would look closer to slider_rounded_corners appearance.

[Samillion]

Can you make a before and after demo. Ideally it would look closer to slider_rounded_corners appearance.

I'm out right now, but can post previews when I'm back home in a couple of hours.

Without changing tooltip font size, setting radius to a static 10 would showcase the result of ((fs + 2 * pad_v) / 2)

[Keith94]

Can you make a before and after demo. Ideally it would look closer to slider_rounded_corners appearance.

I'm out right now, but can post previews when I'm back home in a couple of hours.

Without changing tooltip font size, setting radius to a static 10 would showcase the result of ((fs + 2 * pad_v) / 2)

Okay, that looks like a good compromise.

[Samillion]

@Keith94 @Xurdejl so, yes to ((fs + 2 * pad_v) / 2)?

[nekoxuee]

I said that instead of static 10 because it creates a perfect pill regardless of font size, in the case of wanting a pill shape of course

[Keith94]

@Keith94 @Xurdejl so, yes to ((fs + 2 * pad_v) / 2)?

Looks good to me!

[Samillion]

Done. Let me know if anything else needs adjusting.

I won't rush merging this so that we can have our time gawking at pills. 😆