Skip to content

fix: pin button tooltip is disabled when ontop_in_topbar activates#652

Merged
Samillion merged 2 commits intomainfrom
ontop_tooltip_fix
Apr 6, 2026
Merged

fix: pin button tooltip is disabled when ontop_in_topbar activates#652
Samillion merged 2 commits intomainfrom
ontop_tooltip_fix

Conversation

@Samillion
Copy link
Copy Markdown
Owner

@Samillion Samillion commented Apr 6, 2026

Changes:

  • Fix pin button tooltip, when ontop_in_topbar=yes then pin/unpin, the tooltip was lost
  • Add windowcontrols_ontop to state
  • Remove unused playlist_loop state
  • Remove ontop_in_topbar state
    • Use direct window controls, ontop state, and user options check instead
  • Add make_escaped_title() helper to reduce code repetition
  • Eliminate redundancy with inline logic checks
    • All of them had values already assigned in initiation, so they will never be nil
  • Replace check on tooltip_hints from empty string to nil
  • Draw tooltip if it's not nil, instead of it's not empty string

@Samillion Samillion merged commit ee46531 into main Apr 6, 2026
@Samillion Samillion deleted the ontop_tooltip_fix branch April 6, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant