Skip to content

refactor: initiate file_size_normalized state as nil#706

Merged
Samillion merged 1 commit into
mainfrom
download_approx_size
Apr 23, 2026
Merged

refactor: initiate file_size_normalized state as nil#706
Samillion merged 1 commit into
mainfrom
download_approx_size

Conversation

@Samillion
Copy link
Copy Markdown
Owner

@Samillion Samillion commented Apr 23, 2026

Changes:

  • Initiate file_size_normalized state as nil
  • Adjust file_size_normalized in check_path_url() instead of file-loaded event
    • check_path_url() is already called there
    • Should only be adjusted if is_url() and if download button is enabled

The purpose of this refactor:

  • Structurally, it makes sense this way
  • It prepares possibility to use language locales for download related states in the future

@Samillion Samillion merged commit 786dc90 into main Apr 23, 2026
@Samillion Samillion deleted the download_approx_size branch April 23, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant