Skip to content

fix: monitor stock osc value early #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samillion merged 2 commits into from
Oct 21, 2024
Merged

fix: monitor stock osc value early #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7282e1
fix: disable stock osc.lua early
Samillion Oct 21, 2024
355168d
Document disabling stock osc
Samillion Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ A sleek and modern OSC for [mpv](https://mpv.io/), this project is a fork of Mod
## Features

- 🎨 Modern, customizable interface
- 🖼️ Video thumbnail previews on seek
- 🖼️ Video thumbnail previews on seek (with [thumbfast](https://github.com/po5/thumbfast))
- 📄 Interactive playlist and chapter lists
- 🌐 Multi-language support
- ⌨️ Configurable controls
Expand All @@ -37,21 +37,24 @@ See the [Color Customization](docs/USER_OPTS.md#colors) section in the configura

## Installation

1. **Copy Files**
1. **Disable Stock OSC**
- Add `osc=no` in your `mpv.conf`

2. **Copy Files**

- Place `modernz.lua` in your mpv scripts directory
- Place `Material-Design-Iconic-Round.ttf` in your mpv fonts directory
- (OPTIONAL) Place `thumbfast.lua` in your mpv scripts directory

2. **Locations**
3. **Locations**

```
Linux: ~/.config/mpv/
Windows: C:/Users/%username%/AppData/Roaming/mpv/
macOS: ~/Library/Application Support/mpv/
```

3. **Folder Structure**
4. **Folder Structure**
```
mpv/
├── fonts/
Expand Down
10 changes: 3 additions & 7 deletions modernz.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ local language = {
},
}

mp.observe_property("osc", "bool", function(name, value) if value == true then mp.set_property("osc", "no") end end)

-- Load external locales if available
local locale_file = mp.find_config_file('scripts/modernz-locale.lua')
if locale_file then
Expand Down Expand Up @@ -2561,7 +2563,7 @@ tick = function()
mp.disable_key_bindings("showhide_wc")
state.showhide_enabled = false
end
elseif state.fullscreen and user_opts.showfullscreen
elseif (state.fullscreen and user_opts.showfullscreen)
or (not state.fullscreen and user_opts.showwindowed) then

-- render the OSC
Expand Down Expand Up @@ -2623,12 +2625,6 @@ local function set_tick_delay(_, display_fps)
tick_delay = 1 / display_fps
end

mp.observe_property("osc", "bool", function(name, value)
if value == true then
mp.set_property("osc", "no")
end
end)

mp.register_event("shutdown", shutdown)
mp.register_event("start-file", request_init)
mp.observe_property("track-list", "native", request_init)
Expand Down