Skip to content

refactor: remove unused maxchars dead code #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samillion merged 1 commit into from
May 2, 2026
+0 −14
Merged

refactor: remove unused maxchars dead code #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions modernz.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,19 +1771,6 @@ local function render_elements(master_ass, osc_vis, wc_vis)
buttontext = element.content -- text objects
end

local maxchars = element.layout.button.maxchars
if maxchars ~= nil and #buttontext > maxchars then
local max_ratio = 1.25 -- up to 25% more chars while shrinking
local limit = math.max(0, math.floor(maxchars * max_ratio) - 3)
if #buttontext > limit then
while (#buttontext > limit) do
buttontext = buttontext:gsub(".[\128-\191]*$", "")
end
buttontext = buttontext .. "..."
end
buttontext = string.format("{\\fscx%f}", (maxchars/#buttontext)*100) .. buttontext
end

-- add hover effects
local button_lo = element.layout.button
local is_clickable = element.eventresponder and (element.eventresponder["mbtn_left_down"] ~= nil or element.eventresponder["mbtn_left_up"] ~= nil)
Expand Down Expand Up @@ -1998,7 +1985,6 @@ local function add_layout(name)

if elements[name].type == "button" then
elements[name].layout.button = {
maxchars = nil,
hoverstyle = osc_styles.element_hover,
}
elseif elements[name].type == "slider" then
Expand Down