Conversation
Add an enum of all (supported) ARM and RISC-V instructions and implement a parser from a text file of asm to the instruction enums. * **Instruction Enum**: Add `Instruction` enum in `src/instruction.rs` with all ARM and RISC-V instructions. * **Parser Implementation**: Implement `parse_asm` function in `src/main.rs` to parse asm text files into `Instruction` enums. * **Binary Translation**: Update `binary_translate` function in `src/main.rs` to use `parse_asm` for translation. * **Dependencies**: Add `strum` and `strum_macros` dependencies in `Cargo.toml` for enum parsing. * **Tests**: Add tests in `test/parse_asm.rs` to verify parsing functionality and in `test/binary_translate.rs` to verify translation functionality.
Samir-Rashid
force-pushed
the
add-instruction-enum-parser
branch
from
d0c0b6e to
c0d1a32
Compare
trdavidt
approved these changes
Jan 29, 2025
|
dis i like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an enum of all ARM and RISC-V instructions and implement a parser from a text file of asm to the instruction enums.
Instructionenum insrc/instruction.rswith all ARM and RISC-V instructions.parse_asmfunction insrc/main.rsto parse asm text files intoInstructionenums.binary_translatefunction insrc/main.rsto useparse_asmfor translation.strumandstrum_macrosdependencies inCargo.tomlfor enum parsing.test/parse_asm.rsto verify parsing functionality and intest/binary_translate.rsto verify translation functionality.