Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 92.83% 92.84%
=======================================
Files 140 141 +1
Lines 5054 5115 +61
Branches 825 836 +11
=======================================
+ Hits 4692 4749 +57
- Misses 219 226 +7
+ Partials 143 140 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
babenek
requested review from
404DevVP,
Dmitriy-NK,
Yullia,
csh519,
iuriimet,
kmnls and
xDizzix
Dmitriy-NK
left a comment
Dmitriy-NK
left a comment
There was a problem hiding this comment.
Thank you for improvement. Please, check some minor remark from me.
| """Implements deb (ar) scanning""" | ||
|
|
||
| def data_scan( | ||
| self, # |
There was a problem hiding this comment.
Please remove blank comments from code
| self, # | |
| self, |
There was a problem hiding this comment.
unfortunately, the sign is necessary to keep formatting yapf suitable
| data_provider: DataContentProvider, # | ||
| depth: int, # | ||
| recursive_limit_size: int) -> Optional[List[Candidate]]: | ||
| """Extracts data file from ar archive and launches data_scan""" |
There was a problem hiding this comment.
Please leave only 'archive' or be more specific.
| @@ -54,6 +56,7 @@ class DeepScanner( | |||
| Pkcs12Scanner, # | |||
| PptxScanner, # | |||
| TarScanner, # | |||
There was a problem hiding this comment.
Same as previous, please remove blank comments from code
5 participants
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.