[draft] Handle dynamic dimensions in Squeeze shape inference#14882
[draft] Handle dynamic dimensions in Squeeze shape inference#14882mbencer wants to merge 5 commits intoSamsung:masterfrom
Conversation
This commit skip verification of squeezed dimension if such dimension is dynamic. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
This commit excludes Squeeze_dynamic_000 because TestDataGenerator does not support unknown dimensions. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
This commit adds TFLiteRecipe for dynamic shape Squeeze. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
This commit adds Squeeze_dynamic_000 to circle2circle-dredd-recipe-test. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
| Add(Inf_Pad_000 PASS) | ||
| Add(Inf_StridedSlice_000 PASS) | ||
| Add(Inf_StridedSlice_001 PASS) | ||
| Add(Squeeze_dynamic_000 PASS) |
There was a problem hiding this comment.
1/ plz follow naming convention
2/ add test.rule like others
There was a problem hiding this comment.
Q) what do you want to test with this model?
There was a problem hiding this comment.
1/ plz follow naming convention
done
2/ add test.rule like others
done
Q) what do you want to test with this model?
I want to test scenario (only shape inference) when squeezed dimension is unknown
There was a problem hiding this comment.
@seanshpark If you find a moment please take a look ;)
There was a problem hiding this comment.
changes in this PR looks OK. plz update related PRs.
There was a problem hiding this comment.
The related PRs are already updated
There was a problem hiding this comment.
The related PRs are already updated
plz double check
| ASSERT_EQ(1, shape.dim(2).value()); | ||
| } | ||
|
|
||
| TEST(ShapeRuleTest, neg_squeeze_incorrect_dim) |
There was a problem hiding this comment.
| TEST(ShapeRuleTest, neg_squeeze_incorrect_dim) | |
| TEST(ShapeRuleTest, neg_squeeze_incorrect_dim_NEG) |
mbencer
force-pushed
the
mbencer/SqueezeDynDim
branch
from
0c3012d to
460b621
Compare
|
All PRs were merged |
2 participants
This commit skip verification of squeezed dimension if such dimension is dynamic.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com
Issue: #14791