Skip to content

[onert] Stridedslice supports rank 5 input and int32 dtype for begin,end,stride.#15187

Merged
chunseoklee merged 5 commits intoSamsung:masterfrom
seockho-kim:stridedslice
Apr 21, 2025
Merged

[onert] Stridedslice supports rank 5 input and int32 dtype for begin,end,stride.#15187
chunseoklee merged 5 commits intoSamsung:masterfrom
seockho-kim:stridedslice

Conversation

@seockho-kim
Copy link
Copy Markdown
Contributor

  • StridedSlice now supports rank 5 input tensor.
  • StridedSlice now supports int32 dtype for begin, end, strides.

for #15186

- StridedSlice now supports rank 5 input tensor.
- StridedSlice now supports int32 dtype for begin, end, strides.

ONE-DCO-1.0-Signed-off-by: Seockho Kim seockho.kim@samsung.com
ONE-DCO-1.0-Signed-off-by: Seockho Kim seockho.kim@samsung.com
@seockho-kim seockho-kim requested a review from a team April 18, 2025 07:57
ONE-DCO-1.0-Signed-off-by: Seockho Kim seockho.kim@samsung.com
@seockho-kim seockho-kim marked this pull request as ready for review April 18, 2025 08:10
Comment thread runtime/compute/cker/include/cker/Types.h
ragmani
ragmani previously approved these changes Apr 21, 2025
Copy link
Copy Markdown
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunseoklee
Copy link
Copy Markdown
Contributor

@seockho-kim Please add 1 positive test. Am I missing something ?

@seockho-kim
Copy link
Copy Markdown
Contributor Author

@seockho-kim Please add 1 positive test. Am I missing something ?

I've searched existing test code to add test 5 dimensions in StridedSlice, but I couldn't find.
Then I only added Shape test.
Do you mean StridedSlice test?

@chunseoklee
Copy link
Copy Markdown
Contributor

I've searched existing test code to add test 5 dimensions in StridedSlice, but I couldn't find.

Any reason not to create StridedSlice test with 5-d input ? AFAIU, you have at least target model with this type op ?

Do you mean StridedSlice test?

Yes.

@seockho-kim
Copy link
Copy Markdown
Contributor Author

I've searched existing test code to add test 5 dimensions in StridedSlice, but I couldn't find.

Any reason not to create StridedSlice test with 5-d input ? AFAIU, you have at least target model with this type op ?

Do you mean StridedSlice test?

Yes.

OK, I'll create StridedSlice test for 5D input.
I'm testing florence2 and got into this issue.

- To test 5D input, testcases are added.

ONE-DCO-1.0-Signed-off-by: Seockho Kim seockho.kim@samsung.com
ragmani
ragmani previously approved these changes Apr 21, 2025
To test StridedSlice 5d input case, tests added to nnfw api test.

ONE-DCO-1.0-Signed-off-by: Seockho Kim seockho.kim@samsung.com
Copy link
Copy Markdown
Contributor

@chunseoklee chunseoklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@chunseoklee chunseoklee merged commit 19f27bc into Samsung:master Apr 21, 2025
10 checks passed
@seockho-kim seockho-kim deleted the stridedslice branch April 21, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants