Skip to content

Conversation

@mbencer
Copy link
Contributor

@mbencer mbencer commented Apr 24, 2025

This commit resolves warning "circle_resizer::operator<< has not been declared within ‘circle_resizer’"

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com

Draft: #14727

This commit resolves warning "circle_resizer::operator<< has not been declared within ‘circle_resizer’"

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com
@mbencer mbencer requested a review from jinevening April 24, 2025 11:58
@mbencer
Copy link
Contributor Author

mbencer commented Apr 24, 2025

now we have:

/home/m.bencer/workspace/ONE_fork/compiler/circle-resizer/src/Shape.cpp:86:15: warning: ‘std::ostream& circle_resizer::operator<<(std::ostream&, const circle_resizer::Shape&)’ has not been declared within ‘circle_resizer’
   86 | std::ostream &circle_resizer::operator<<(std::ostream &os, const Shape &shape)
      |               ^~~~~~~~~~~~~~
In file included from /home/m.bencer/workspace/ONE_fork/compiler/circle-resizer/src/Shape.cpp:17:
/home/m.bencer/workspace/ONE_fork/compiler/circle-resizer/src/../include/Shape.h:91:24: note: only here as a ‘friend’
   91 |   friend std::ostream &operator<<(std::ostream &os, const Shape &shape);

Copy link
Collaborator

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit 0d44ed3 into Samsung:master Apr 25, 2025
7 checks passed
@mbencer mbencer deleted the mbencer/ShapeWarning branch May 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants