Skip to content

[infra] Fix relative paths in nnas, nncc and nnfw scripts#16251

Merged
jinevening merged 1 commit intoSamsung:masterfrom
arkq:bash-fix-relative-path-infra
Nov 2, 2025
Merged

[infra] Fix relative paths in nnas, nncc and nnfw scripts#16251
jinevening merged 1 commit intoSamsung:masterfrom
arkq:bash-fix-relative-path-infra

Conversation

@arkq
Copy link
Contributor

@arkq arkq commented Oct 28, 2025

This commit fixes the problem where it is not possible to use the nn* scripts outside of the project's root directory.

Testing

Verified locally that now it is possible to list and run commands when outside of the repo dir:

$ ONE/nnas
Usage: ONE/nnas [COMMAND] ...
Command:
  copyright-check
  ...
  verify-package
$ ONE/nncc configure
-- The C compiler identification is GNU 13.3.0
  ...
$ ONE/nnfw configure
-- Building for x86-64 Linux
  ...

ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy a.bokowy@samsung.com

@seanshpark
Copy link
Contributor

This commit fixes the problem where it is not possible to use the nn* scripts outside of the project's root directory.

why do you run the script outside of the folder?

@arkq
Copy link
Contributor Author

arkq commented Oct 28, 2025

why do you run the script outside of the folder?

Sometimes it's easier for me to rebuild something without changing current directory, e.g. I'm in infra/ so git grep show only files inside this directory. Using ../nnfw build is faster. However, now, ../nnfw does not show available commands:

$ ../nnfw
Usage: ../nnfw [COMMAND] ...
Command:
  *

So, this PR is a general fix for nn* scripts to address that.

This commit fixes the problem where it is not possible to use the nn*
scripts outside of the project's root directory.

ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
@arkq arkq force-pushed the bash-fix-relative-path-infra branch from 721d5ca to 0505d1f Compare October 30, 2025 09:41
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit d308930 into Samsung:master Nov 2, 2025
14 checks passed
@arkq arkq deleted the bash-fix-relative-path-infra branch November 2, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants