Skip to content

[circle-mlir/models] Add Conv2d_F32_R4_p11_g2 test model#16395

Merged
hseok-oh merged 1 commit intoSamsung:masterfrom
batcheu:add_conv2d_test
Feb 25, 2026
Merged

[circle-mlir/models] Add Conv2d_F32_R4_p11_g2 test model#16395
hseok-oh merged 1 commit intoSamsung:masterfrom
batcheu:add_conv2d_test

Conversation

@batcheu
Copy link
Copy Markdown
Contributor

@batcheu batcheu commented Feb 23, 2026

It adds the Conv2d test model with padding and group set.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee jonghwa3.lee@samsung.com


@batcheu batcheu requested review from hseok-oh and shs-park February 23, 2026 07:44
shs-park
shs-park previously approved these changes Feb 23, 2026
Copy link
Copy Markdown
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)


_model_ = net_Conv2d()

_inputs_ = torch.randn(1, 256, 200, 320)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it too big to test? Why don't you reduce input size?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a bit large but I want to use same arguments as the issued model.
Do you want me to reduce the size?

Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to reduce the size?

Right. I want to reduce test time as possible

  • For faster test on developer environment
  • To reduce CI infra overhead

It adds the Conv2d test model with padding and group set.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
@batcheu batcheu changed the title [circle-mlir/models] Add Conv2d_F32_R4_p11_g32 test model [circle-mlir/models] Add Conv2d_F32_R4_p11_g2 test model Feb 24, 2026
class net_Conv2d(torch.nn.Module):
def __init__(self):
super().__init__()
self.op = torch.nn.Conv2d(4, 4, 1, padding=(1, 1), groups=2)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced tensor size referring to @hseok-oh comment.

loc("/op/Conv/split_input"): error: 'Circle.split' op output #0 should be 'tensor<1x5x5x2xf32>' instead got 'tensor<1x3x3x2xf32>

@batcheu
Copy link
Copy Markdown
Contributor Author

batcheu commented Feb 24, 2026

@shs-park , @hseok-oh
I updated the commit, PTAL ;)

Copy link
Copy Markdown
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 1d538b4 into Samsung:master Feb 25, 2026
7 checks passed
@batcheu batcheu deleted the add_conv2d_test branch February 27, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants