[circle-mlir] Update intype after padding in ConvOp#16406
Merged
hseok-oh merged 2 commits intoSamsung:masterfrom Feb 27, 2026
Merged
[circle-mlir] Update intype after padding in ConvOp#16406hseok-oh merged 2 commits intoSamsung:masterfrom
hseok-oh merged 2 commits intoSamsung:masterfrom
Conversation
After inserting padding on the input tensor, the intype variable is now updated to reflect the type of the padded input. ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
hseok-oh
reviewed
Feb 25, 2026
| if (GetPads(op.getPads(), padsValue)) | ||
| { | ||
| inputPreTr = insertPad(rewriter, op_name, input, outtype, padsValue); | ||
| intype = mlir::dyn_cast_or_null<mlir::RankedTensorType>(inputPreTr.getType()); |
Contributor
There was a problem hiding this comment.
How about add debug message such as line 82?
Contributor
Author
There was a problem hiding this comment.
I added a debug message as you commented ;)
...
ConvConv name: /op/Conv
ConvConv auto_pad: NOTSET
ConvConv dilations: [1, 1]
ConvConv group: 32
ConvConv kernel_shape: [3, 3]
ConvConv pads: [1, 1, 1, 1]
ConvConv strides: [1, 1]
ConvConv intype: tensor<1x256x200x320xf32>
ConvConv outtype: tensor<1x256x200x320xf32>
ConvConv padH: 202, padW: 322
ConvConv Pad: loc("/op/Conv/pads")
ConvConv intype after padding: tensor<1x256x202x322xf32> // newly added message
...
ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After inserting padding on the input tensor, the intype variable is now updated to reflect the type of the padded input.
ONE-DCO-1.0-Signed-off-by: Jonghwa Lee jonghwa3.lee@samsung.com