Skip to content

[circle-mlir] Activate tests for ConvTranspose#16470

Merged
mhs4670go merged 1 commit intoSamsung:masterfrom
shs-park:circle-mlir/activate-dynamic-convtranspose-tests
Apr 1, 2026
Merged

[circle-mlir] Activate tests for ConvTranspose#16470
mhs4670go merged 1 commit intoSamsung:masterfrom
shs-park:circle-mlir/activate-dynamic-convtranspose-tests

Conversation

@shs-park
Copy link
Copy Markdown
Contributor

@shs-park shs-park commented Apr 1, 2026

This activates the model tests for the ConvTranspose pass with dynamic-shape inputs.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park shs.park@samsung.com

This activates the model tests for the ConvTranspose pass with
dynamic-shape inputs.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park self-assigned this Apr 1, 2026
Copy link
Copy Markdown
Contributor Author

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shs-park shs-park requested a review from a team April 1, 2026 06:44
@shs-park shs-park added the PR/ready for review It is ready to review. Please review it. label Apr 1, 2026
AddModel(ConvTranspose2d_F32_R4_p11_nobias)
# AddModel(ConvTranspose2d_F32_R4_unk_bh)
# AddModel(ConvTranspose2d_F32_R4_unk_bw)
# AddModel(ConvTranspose2d_F32_R4_unk_bh) --> Does't support dynamic shape output
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curiosity, even though it can't resolve dynamic shape outputs, the codes has been introduced because circle can do it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not exactly because circle already fully supports all such dynamic outputs.

The point was that partially dynamic shapes in intermediate IR are still worth preserving when possible.
AFAIK, they may be refined later by subsequent passes or by concrete runtime input shapes.
So I wanted to avoid rejecting those cases too early in the conversion pipeline.

Please let me know if I got anything wrong or missed something.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments. I just wanted to check if there's some passes or other workflows that validates the graph.

@mhs4670go mhs4670go merged commit a63b5c0 into Samsung:master Apr 1, 2026
7 checks passed
@shs-park shs-park deleted the circle-mlir/activate-dynamic-convtranspose-tests branch April 1, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants