Skip to content

[onecc-docker] Add test directory#9731

Closed
jyoungyun wants to merge 1 commit intoSamsung:masterfrom
jyoungyun:onecc_docker/add_tests
Closed

[onecc-docker] Add test directory#9731
jyoungyun wants to merge 1 commit intoSamsung:masterfrom
jyoungyun:onecc_docker/add_tests

Conversation

@jyoungyun
Copy link
Contributor

This commit adds test directory.
The test directory helps to test onecc-docker command line tool by installing prepare_test_materials.sh script and generating runtestall.sh script automatically.

ONE-DCO-1.0-Signed-off-by: Jiyoung Yun jy910.yun@samsung.com

This commit adds test directory.
The test directory helps to test `onecc-docker` command line tool
by installing prepare_test_materials.sh script and generating
runtestall.sh script automatically.

ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
@jyoungyun jyoungyun requested a review from a team September 19, 2022 02:18
@jyoungyun
Copy link
Contributor Author

I didn't test it yet. It is just a reference test directory.

Comment on lines +11 to +12
file(APPEND "${DRIVER_SCRIPT}" "SCRIPT_PATH=$(cd $(dirname $\{BASH_SOURCE\[0\]\}) && pwd)\n")
file(APPEND "${DRIVER_SCRIPT}" "pushd $SCRIPT_PATH > /dev/null\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyoungyun , as a result of performing cmake on the file, it seems that the newline is not applied.

When executed, the result of the file runtestall.sh.

SCRIPT_PATH=$(cd $(dirname $\{BASH_SOURCE\[0\]\}) && pwd) \npushd $SCRIPT_PATH > /dev/null

When I modified it like this, I think the newline is applied well. Please check.

Suggested change
file(APPEND "${DRIVER_SCRIPT}" "SCRIPT_PATH=$(cd $(dirname $\{BASH_SOURCE\[0\]\}) && pwd)\n")
file(APPEND "${DRIVER_SCRIPT}" "pushd $SCRIPT_PATH > /dev/null\n")
file(APPEND "${DRIVER_SCRIPT}" "SCRIPT_PATH=$(cd $(dirname $\{BASH_SOURCE\[0\]\}) && pwd)")
file(APPEND "${DRIVER_SCRIPT}" "\n")
file(APPEND "${DRIVER_SCRIPT}" "pushd $SCRIPT_PATH > /dev/null\n")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyoungyun
As we talked in the previous meeting, we will upload a new PR after modifying that part. Can you give me an opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I modified it like this, I think the newline is applied well. Please check.

I didn't test this script. If there is something to modify, please fix it. :)

As we talked in the previous meeting, we will upload a new PR after modifying that part. Can you give me an opinion?

Yes, right. Please upload the code that constitutes the test environment first. :)

@jyoungyun jyoungyun closed this Nov 2, 2023
@jyoungyun jyoungyun deleted the onecc_docker/add_tests branch November 2, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants