Fix mising condition of RemoveRedundantToCopy pass#155
Merged
mhs4670go merged 1 commit intoSamsung:mainfrom Jun 17, 2025
Merged
Fix mising condition of RemoveRedundantToCopy pass#155mhs4670go merged 1 commit intoSamsung:mainfrom
mhs4670go merged 1 commit intoSamsung:mainfrom
Conversation
This commit considers memory_format in RemoveRedundantToCopy pass and fix related test. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
Seunghui98
reviewed
Jun 17, 2025
|
|
||
| self.run_value_test(RemoveRedundantToCopy()) | ||
| self.assertEqual(num_of_ops(self.exported_program(), ops.aten.to_copy), 0) | ||
| self.assertEqual(num_of_ops(self.exported_program(), ops.aten.to_copy), 1) |
There was a problem hiding this comment.
After adding this condition for the pass, I see that this test was changed to a negative test.
so, I guess the number of ops.aten.to_copy operations remained unchanged (1 → 1).
Is my understanding correct? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit considers memory_format in RemoveRedundantToCopy pass and fix related test.
We are supporting only contiguous format now.
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com