Fix crash vulnerabilities in path animation and layer parent handling#593
Open
mihashco wants to merge 1 commit into
Open
Fix crash vulnerabilities in path animation and layer parent handling#593mihashco wants to merge 1 commit into
mihashco wants to merge 1 commit into
Conversation
Two stability issues have been addressed: 1. PathData specialization: Added missing empty-frames guard in the Property<PathData>::value() method at lottiemodel.h. This prevents a null pointer dereference when animation keyframes are discarded during parsing, leaving the frames array empty. 2. Layer parent recursion: Added depth limiting to Layer::matrix() at lottieitem.cpp to prevent stack overflow from cyclic parent layer references. The method now uses an internal overload with a depth counter that returns an identity matrix when exceeding 64 levels. Files changed: - src/lottie/lottiemodel.h: Added empty check before accessing frames - src/lottie/lottieitem.h: Declared overloaded matrix() with depth param - src/lottie/lottieitem.cpp: Implemented depth-limited matrix traversal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stability issues have been addressed:
PathData specialization: Added missing empty-frames guard in the Property::value() method at lottiemodel.h. This prevents a null pointer dereference when animation keyframes are discarded during parsing, leaving the frames array empty.
Layer parent recursion: Added depth limiting to Layer::matrix() at lottieitem.cpp to prevent stack overflow from cyclic parent layer references. The method now uses an internal overload with a depth counter that returns an identity matrix when exceeding 64 levels.
Files changed: