First #1
Open
First #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekulta
reviewed
Sep 18, 2024
Comment on lines
+22
to
+24
| /* логика установки скорости с валидацией введенных симоволов и рекурсивно заставляю ввести | ||
| верное значение с указанием какие значения от него ожидаются | ||
| */ |
There was a problem hiding this comment.
В целом по коду уже понятно что делает функция. Здесь не нужен комментарий.
There was a problem hiding this comment.
Так же комментарии принято писать на английском, но это, конечно, не обязтательно.
Comment on lines
+26
to
+41
| Scanner scanner = new Scanner(System.in); | ||
| System.out.println("Введите скорость автомобиля №" + num + ":"); | ||
| int curentSpeed; | ||
| try { | ||
| curentSpeed = scanner.nextInt(); | ||
| if (curentSpeed > 0 && curentSpeed <=250){ | ||
| speed=curentSpeed; | ||
| }else{ | ||
| System.out.println("Введенное значение находится вне пределов от 1 до 250 включительно. Попробуйте снова."); | ||
| setSpeed(num); | ||
| } | ||
| } catch (InputMismatchException e){ | ||
| System.out.println("Необходимо ввести число от 1 до 250 включительно."); | ||
| setSpeed(num); | ||
| } | ||
| } |
There was a problem hiding this comment.
Логичнее было бы хранить num внутри самого класса Car как переменную и задавать в конструкторе.
There was a problem hiding this comment.
Так же логично было бы вынести всю логику по считыванию из класса Car и оставить тут только простой геттер.
| } | ||
| //Вычисляем победителя | ||
| void whoWinn() { | ||
| Car car = new Car(); |
There was a problem hiding this comment.
Переменная создаётся и не используется.
kekulta
reviewed
Sep 18, 2024
Comment on lines
+29
to
+40
| try { | ||
| curentSpeed = scanner.nextInt(); | ||
| if (curentSpeed > 0 && curentSpeed <=250){ | ||
| speed=curentSpeed; | ||
| }else{ | ||
| System.out.println("Введенное значение находится вне пределов от 1 до 250 включительно. Попробуйте снова."); | ||
| setSpeed(num); | ||
| } | ||
| } catch (InputMismatchException e){ | ||
| System.out.println("Необходимо ввести число от 1 до 250 включительно."); | ||
| setSpeed(num); | ||
| } |
There was a problem hiding this comment.
try-catch довольно дорогая операция, правильнее было бы использовать hasNextInt()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.