Skip to content

Fixed MySqlDataReader not disposed by EntityFrameworkCore #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Fixed MySqlDataReader not disposed by EntityFrameworkCore #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions Source/MySql.Data/datareader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
namespace MySql.Data.MySqlClient
{
/// <include file='docs/MySqlDataReader.xml' path='docs/ClassSummary/*'/>
public sealed partial class MySqlDataReader : IDisposable
public sealed partial class MySqlDataReader : DbDataReader
{
// The DataReader should always be open when returned to the user.
private bool isOpen = true;
Expand Down Expand Up @@ -1035,14 +1035,10 @@ private void Throw(Exception ex)
throw ex;
}

public new void Dispose()
protected override void Dispose(bool disposing)
{
Dispose(true);
GC.SuppressFinalize(this);
}
base.Dispose(disposing);

internal new void Dispose(bool disposing)
{
if (disposing)
{
Close();
Expand Down