fix(graph): resolve color fallback so SVG nodes don't render black#94
fix(graph): resolve color fallback so SVG nodes don't render black#94Jose-Gael-Cruz-Lopez wants to merge 1 commit into
Conversation
SVG presentation attributes (fill=) don't resolve CSS custom properties, so a missing per-course color fell through to var(--c-sage) and rendered as black. Adds a deterministic hex palette + paletteFor(seed) helper and wires it into the Dashboard, Tree, and KnowledgeGraph fallbacks. Also bumps subject-root radius from 22 to 28 so course family centers stand out from concept nodes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
frontend | 84bb0e4 | Commit Preview URL Branch Preview URL |
May 05 2026, 10:19 PM |
|
Folded into #93 — keeping rename feature and graph color fix in a single PR. |
Summary
fill=) don't resolve CSS custom properties — when the backend doesn't supply a per-course color, thevar(--c-sage)fallback was rendering black.paletteFor(seed)helper inlib/data.tsand wires it into the Dashboard, Tree, and KnowledgeGraph fallback paths.Test plan
npx tsc --noEmitinfrontend/— cleancourse_colorand confirm nodes render with a stable hue (not black)Note
A sibling fallback exists in
screens/Learn.tsx#apiToGraphNode. It's intentionally left untouched here because PR #93 is in flight on that file. Once both land, a one-liner can switch Learn's fallback topaletteFor(...)for consistency.🤖 Generated with Claude Code