feat: add structured error handling and conditional breakpoint support #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add structured error framework with error codes and actionable suggestions - Implement conditional breakpoints with logging (bpcnd, bplog, bpcmd support) - Add module dump functionality with PE header reconstruction - Add API logging breakpoints for monitoring Windows API calls - Add breakpoint log retrieval and clearing endpoints - Integrate structured errors into address validation and API error handling - Export structured error utilities in utils __init__ New files: - src/utils/structured_errors.py: Error codes, structured error classes, factory functions - tests/test_structured_errors.py: Comprehensive tests for structured errors - tests/test_module_dump.py: Tests for module dump tool formatting
- Add path traversal protection to x64dbg_dump_memory and x64dbg_dump_module using sanitize_output_path() to restrict output to ~/.binary_mcp_output/dumps - Add 100MB size limit to dump_memory in both dynamic_tools.py and bridge.py (defense-in-depth) to prevent memory exhaustion attacks - Add TestSecurityValidations test class with 4 new tests for security checks
…ndency Tests now use hardcoded expected values instead of importing constants from dynamic_tools.py, which has heavy FastMCP dependencies that fail in CI environments. The bridge.py import test still validates the actual constant value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files: