Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes most of my old testing framework and combines it in with the work that James did. This also fixes the issues with the H5 test not passing. The following issues are known, but are a bit beyond the scope of the current PR:
expected_valuesandexpected_metadata. This is likely my next PRround_tripshould be true for all tests, but it is currently failing on some tests, I didn't want to mark those tests as broken, because all of the loading infrastructure should still be tests, but some of these files cannot survive a round trip through h5.There's also a bit of a future refactor to perform because the test framework was designed around the ASCII reader, where files only contain a single dataset. The XML and HDF files can contain multiple datasets, so a little infrastructure was added to choose only a single dataset from the file. However, a better system would be to test the ASCII and SESANS as special cases containing only a single dataset and generally work with multiple data sets per file.