Skip to content

Fixes stray references to run.py#3733

Merged
DrPaulSharp merged 1 commit into
mainfrom
run-py
Nov 11, 2025
Merged

Fixes stray references to run.py#3733
DrPaulSharp merged 1 commit into
mainfrom
run-py

Conversation

@DrPaulSharp
Copy link
Copy Markdown
Contributor

Description

The test file run_one.py contains a reference to the now-removed file run.py. This PR updates it to __main__.py.

How Has This Been Tested?

Tested that the file correctly runs a single test file.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Copy Markdown
Member

@jellybean2004 jellybean2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@llimeht
Copy link
Copy Markdown
Contributor

llimeht commented Nov 11, 2025

My thinking was that this file should just go (along with some others). Our test runner is pytest not unittest, so who knows whether this even works in general

(I had put it in my collection of nitpicks to deal with one day)

@DrPaulSharp
Copy link
Copy Markdown
Contributor Author

My thinking was that this file should just go (along with some others). Our test runner is pytest not unittest, so who knows whether this even works in general

(I had put it in my collection of nitpicks to deal with one day)

Yeah, that makes sense to me. This just makes the file work without crashing for now, but I see no reason to retain it long term.

@DrPaulSharp DrPaulSharp merged commit b220a5a into main Nov 11, 2025
30 checks passed
@DrPaulSharp DrPaulSharp deleted the run-py branch November 11, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants