Skip to content

Building custom branches#3769

Merged
wpotrzebowski merged 3 commits into
mainfrom
custom_builds
Nov 18, 2025
Merged

Building custom branches#3769
wpotrzebowski merged 3 commits into
mainfrom
custom_builds

Conversation

@wpotrzebowski
Copy link
Copy Markdown
Contributor

@wpotrzebowski wpotrzebowski commented Nov 16, 2025

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Once merged it can work as explained here https://docs.github.com/en/actions/how-tos/manage-workflow-runs/manually-run-a-workflow

Fixes # (issue/issues)

How Has This Been Tested?

Unfortunately, there is not an easy way to test It until it is merged to main.
The parts of it have been tested with REST API.
Once it is merged, developers documention will be supplied with the actual screenshots.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@llimeht
Copy link
Copy Markdown
Contributor

llimeht commented Nov 16, 2025

Looks good

(please rebase and squash the commits so that the accidentally included files never hit the git history)

@wpotrzebowski wpotrzebowski marked this pull request as ready for review November 16, 2025 10:07
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
jellybean2004 and others added 2 commits November 16, 2025 11:16
* Adds fold as a class property similar to BoxInteractor

* Sets fold to true by default
Cleaned up becuse some files were comitted accidently

Updated workflow

Test workflow to see if the approach works. Not meant to be pushed to the main branch

Update test workflow

Removing test workflow
@llimeht
Copy link
Copy Markdown
Contributor

llimeht commented Nov 18, 2025

Just did a gh workflow run --repo sasview/sasview --ref custom_builds ci.yml -f sasmodels_ref=pr-python-fq and it built sasmodels with that particular branch before feeding it into the rest of the build, so that looks good. (artifacts will be at https://github.com/SasView/sasview/actions/runs/19452421812).

The code path that the bot is talking about wasn't tested when CI was first run on this PR, as the cached wheel was used instead. I deleted the sasmodels cache to force it to build using this code path and it worked fine, so I agree the bot's review is incorrect.

# Get refs from inputs (workflow_call or workflow_dispatch) or default to master
  SASMODELS_REF="master"
  SASDATA_REF="master"
  echo "Using sasmodels ref: $SASMODELS_REF"
  echo "Using sasdata ref: $SASDATA_REF"
 ...

@wpotrzebowski wpotrzebowski merged commit e1c8489 into main Nov 18, 2025
81 of 90 checks passed
@wpotrzebowski wpotrzebowski deleted the custom_builds branch November 18, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants