Building custom branches#3769
Conversation
|
Looks good (please rebase and squash the commits so that the accidentally included files never hit the git history) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Cleaned up becuse some files were comitted accidently Updated workflow Test workflow to see if the approach works. Not meant to be pushed to the main branch Update test workflow Removing test workflow
16f7d53 to
3a04699
Compare
|
Just did a The code path that the bot is talking about wasn't tested when CI was first run on this PR, as the cached wheel was used instead. I deleted the sasmodels cache to force it to build using this code path and it worked fine, so I agree the bot's review is incorrect. |
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Once merged it can work as explained here https://docs.github.com/en/actions/how-tos/manage-workflow-runs/manually-run-a-workflow
Fixes # (issue/issues)
How Has This Been Tested?
Unfortunately, there is not an easy way to test It until it is merged to main.
The parts of it have been tested with REST API.
Once it is merged, developers documention will be supplied with the actual screenshots.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)