Skip to content

Fix for Dmax explorer plot turning into a scatter plot when resetting view#3894

Merged
DrPaulSharp merged 1 commit intomainfrom
isn_dmax_bugfix
Mar 31, 2026
Merged

Fix for Dmax explorer plot turning into a scatter plot when resetting view#3894
DrPaulSharp merged 1 commit intomainfrom
isn_dmax_bugfix

Conversation

@jellybean2004
Copy link
Copy Markdown
Member

Description

This PR fixes an issue with the Dmax explorer of the Inversion perspective.

Clicking the 'reset original view' (shown as a home icon under the plot) would turn the line graph into a scatter plot. This PR fixes it by storing the symbol.

Fixes #3202

How Has This Been Tested?

Manually tested functionality on Windows 11 following the steps in the issue.

Review Checklist:

Documentation

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing

  • The introduced changes comply with SasView license (BSD 3-Clause)

@jellybean2004
Copy link
Copy Markdown
Member Author

@MBartkowiakSTFC @krzywon, would any of you like to review this?

Copy link
Copy Markdown
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Haven't tested functionality.

@MBartkowiakSTFC
Copy link
Copy Markdown

There is still a thing where repeatedly clicking the "Reset original view" on the matplotlib toolbar makes the figure expand, but I think that is a general matplotlib problem. I'm just mentioning it for the record, but this was not part of the original problem.

Screenshot 2026-03-26 at 09 57 06 Screenshot 2026-03-26 at 09 57 14

Copy link
Copy Markdown

@MBartkowiakSTFC MBartkowiakSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out. Looks good, it seems to have fixed the problem.

@DrPaulSharp DrPaulSharp merged commit 06a9f85 into main Mar 31, 2026
48 checks passed
@DrPaulSharp DrPaulSharp deleted the isn_dmax_bugfix branch March 31, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dmax explorer errors on zoom reset

4 participants