Close slicer parameter window with 2D plot#3930
Merged
Merged
Conversation
krzywon
reviewed
May 1, 2026
Contributor
krzywon
left a comment
krzywon
left a comment
There was a problem hiding this comment.
I tested this locally and it seems to work. I do have a couple of questions that could use addressing.
jellybean2004
force-pushed
the
patch_slicer_param_window
branch
from
285cc7d to
0f4c2af
Compare
Member
Author
|
Hey @krzywon, just pushed a commit adding type hints and comments, and rebased. Let me know if you're happy with this. |
krzywon
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the slider parameter window is specific to a 2D plot, it should close automatically if its 2D plot is closed/deleted. This PR adds that behaviour with tests.
Fixes #3929
How Has This Been Tested?
Manually tested and ran newly added tests.
Review Checklist:
Documentation
Installers
Licensing