Conversation
krzywon
approved these changes
Apr 30, 2026
Contributor
krzywon
left a comment
krzywon
left a comment
There was a problem hiding this comment.
Tested and this fixes the issue. Code looks appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two PRs (#3786 & #3863) seem to have been developed & merged in parallel, resulting in a broken SAXS fitting tool. This PR fixes this issue by making the SAXS fitting tool use the new communicator pattern.
I thought about writing a small unit test to verify a model file is actually created from the GSC with the SAXS tool enabled, but the logic is too strongly tied to Qt which I'm not sure how to handle in the tests.
Fixes #3933.
How Has This Been Tested?
Manually tested & verified working.
Review Checklist:
Documentation
Installers
Licensing