Unpin pyausaxs#3953
Merged
Merged
Conversation
DrPaulSharp
approved these changes
May 14, 2026
Contributor
DrPaulSharp
left a comment
There was a problem hiding this comment.
Great, thanks very much for getting on this so quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a small bug in the SasView SAXS calculations for four-column datasets spanning beyond 1Å^-1 due to stale caching in the
AUSAXSbackend. While I managed to fix this stale caching in v1.1.4, I also introduced a new bug which disabled weighted bins for calculations at angles larger than 1Å^-1. This new issue was not caught by my own test suite, but triggered test failures here in SasView.The issue has been fixed in v1.1.5 and additional tests created to avoid this happening again.
Fixes #3952
How Has This Been Tested?
Unit tests pass with unpinned
pyausaxs.Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)