Skip to content

Unpin pyausaxs#3953

Merged
DrPaulSharp merged 1 commit into
mainfrom
3952
May 14, 2026
Merged

Unpin pyausaxs#3953
DrPaulSharp merged 1 commit into
mainfrom
3952

Conversation

@klytje
Copy link
Copy Markdown
Contributor

@klytje klytje commented May 14, 2026

Description

I noticed a small bug in the SasView SAXS calculations for four-column datasets spanning beyond 1Å^-1 due to stale caching in the AUSAXS backend. While I managed to fix this stale caching in v1.1.4, I also introduced a new bug which disabled weighted bins for calculations at angles larger than 1Å^-1. This new issue was not caught by my own test suite, but triggered test failures here in SasView.

The issue has been fixed in v1.1.5 and additional tests created to avoid this happening again.

Fixes #3952

How Has This Been Tested?

Unit tests pass with unpinned pyausaxs.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Copy Markdown
Contributor

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks very much for getting on this so quickly.

@DrPaulSharp DrPaulSharp merged commit 710739b into main May 14, 2026
36 checks passed
@DrPaulSharp DrPaulSharp deleted the 3952 branch May 14, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyausaxs version 1.1.4 causes the tests to fail

2 participants