Skip to content

Do not try to autofill explicit access #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2015
Merged

Do not try to autofill explicit access #385

merged 2 commits into from
Mar 15, 2015

Conversation

@valeriangalliat
Copy link
Member

@valeriangalliat valeriangalliat commented Mar 15, 2015

Should be merged in both master and develop once reviewed.

Tested on sassdoc-theme-default on my side, works as expected for the following cases:

Case Behavior
explicit private without underscore private
explicit public and underscore public
underscore private
nothing public

@pascalduez
Copy link
Member

pascalduez commented Mar 15, 2015

LGTM

@coveralls
Copy link

coveralls commented Mar 15, 2015

Coverage Status

Coverage increased (+0.02%) to 94.09% when pulling 6a0ce30 on hotfix/access-autofil-explicit into ae3ce41 on master.

@valeriangalliat valeriangalliat merged commit 6a0ce30 into master Mar 15, 2015
@valeriangalliat valeriangalliat deleted the hotfix/access-autofil-explicit branch March 25, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@access annotation should override privatePrefix

4 participants

@valeriangalliat @pascalduez @coveralls