🔧 Add code validation standard config#302
Merged
Conversation
rahulpatidar0191
approved these changes
Jan 12, 2022
hillairet
added a commit
that referenced
this pull request
Apr 12, 2022
This reverts commit 8f752a0.
hillairet
added a commit
that referenced
this pull request
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to standardize our code quality tools, I decided to add standard config files for flake8, mypy and isort once I figured out that they can all be overwritten in the app's folder!
Please make sure to check that the documentation makes sense.
I tried to test as much as possible that the standard and overwrite config files work properly in the test app. It will hopefully notice a change in the way one of these tools loads its configurations.
Also starting to use the gitmoji for the PR title! 😉