✨ Include health tests for a PRD docker image #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rahulpatidar0191
commented
Dec 4, 2023
rahulpatidar0191
commented
- Added a condition to run health test on a PRD docker image
- Added a parameter so that all the tests can also run on PRD test image that includes dev dependencies
- Ref:
- Slack conversation
- Tested on this branch
hillairet
suggested changes
Dec 4, 2023
scripts/ValidateCode.sh
Outdated
Comment on lines
18
to
19
| if [[ -n $DEV_ARG ]] | ||
| then |
Contributor
There was a problem hiding this comment.
issue: A better way to do this is to exit early. Instead of having to scroll down to check what happens after this if statement, I then know that everything else below is for DEV only since otherwise we exit the script entirely.
(Check the code below, my bash knowledge is rusty.
Suggested change
| if [[ -n $DEV_ARG ]] | |
| then | |
| if [[ -z $DEV_ARG ]] | |
| then | |
| exit 0 |
hillairet
suggested changes
Dec 5, 2023
scripts/ValidateCode.sh
Outdated
| if [[ -z $DEV_ARG ]] | ||
| then | ||
| exit 0 | ||
| else |
Contributor
There was a problem hiding this comment.
Unnecessary!
Get rid of it and the diff between this PR and main will be a lot smaller too once you revert the indentation of the lines below!
Suggested change
| else |
Co-authored-by: Anthony Hillairet <anthony.hillairet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.