Merged
Conversation
hillairet
approved these changes
May 18, 2022
Collaborator
hillairet
left a comment
hillairet
left a comment
There was a problem hiding this comment.
Nice to have this clean up done!
Collaborator
Author
|
@hillairet do we know of any app that's using the cookie thing from here? Just wonder if we need to flag this as a breaking change. thanks |
Collaborator
|
Yeah that's a breaking change. I don't think it's used though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #131
my understanding is that we only remove the jwtoken used to set cookie with not the jwtoken used for the oauth state/{nonce} param.