🐛 add 10 seconds leeway for session token check on the nbf#175
Merged
Conversation
Collaborator
Author
|
I have update the Please refer to the 2 CI failures in the PR. |
hillairet
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encountering the following
ImmatureSignatureErrorfrom time to time when doing the end to end test with the PIM client.did a bit googling and found that's an existing issue others encountered as well
ref: Session_token Gives Me Error "The Token Is Not Yet Valid (Nbc)"
and the shopify python library has it fixed with the leeway that applies to
nbf,exp,iat:Accept 10 seconds clock skew to avoid ImmatureSignatureError
The solution is applied here as well.