chore: adds new claims from sources#14
Conversation
Review Summary by QodoAdd custom validation rules and new news sources with claims
WalkthroughsDescription• Refactored validator to remove registry-based approach for compatibility • Added custom validation rules via x-oapi-codegen-extra-tags support • Implemented nonempty, nospace, and httpsurl validation rules • Added 8 new news sources and 6 claims from multiple outlets Diagramflowchart LR
A["Validator Refactor"] -->|Simplify| B["Direct Draft202012Validator"]
A -->|Add| C["Custom Validation Rules"]
C -->|Support| D["nonempty, nospace, httpsurl"]
E["New Sources"] -->|Add| F["Al Jazeera, BBC, HT, SCMP"]
F -->|Populate| G["6 New Claims"]
B -->|Integrate| H["Enhanced Validation Pipeline"]
C -->|Integrate| H
File Changes1. scripts/validate.py
|
Code Review by Qodo
1. Conflicting GDP figures
|
Signed-off-by: Amit Singh <singhamitch@outlook.com>
There was a problem hiding this comment.
2 issues found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="claims/ht/india-gdp.yaml">
<violation number="1" location="claims/ht/india-gdp.yaml:2">
P2: The summary conflicts with the title on both fiscal year and GDP figure; keep one consistent claim statement in this record.</violation>
</file>
<file name="claims/nyt/pentagon-google-ai.yaml">
<violation number="1" location="claims/nyt/pentagon-google-ai.yaml:2">
P2: Remove the incorrect statement that the Department of Defense was renamed to the Department of War; it makes the claim record factually inaccurate.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Amit Singh <singhamitch@outlook.com>
No description provided.